OWNERS: Drop release-admins#1040
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 6, 2021
Merged
Conversation
I'm pretty sure this is what Scott meant to do in 7dd81a9 (OWNERS: OTA team now owns all graph changes, 2020-07-14, openshift#330), and he just didn't think to look in the raw/ directory. This also saves us from having to attempt to maintain a release-admins alias (e.g. Alex no longer works for Red Hat, and none of the others have weighed in on graph-data changes in a while now). Most of the folks who used to be in release-admins have direct access to manipulate GitHub labels anyway, so they don't need to go through Prow to drop approval labels on anything; they can just do that directly via GitHub actions.
wking
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is what @sdodson meant to do in 7dd81a9 (#330), and he just didn't think to look in the
raw/directory.This also saves us from having to attempt to maintain a release-admins alias (e.g. Alex no longer works for Red Hat, and none of the others have weighed in on graph-data changes in a while now). Most of the folks who used to be in release-admins have direct access to manipulate GitHub labels anyway, so they don't need to go through Prow to drop approval labels on anything; they can just do that directly via GitHub actions.